search

batteries-included / batteries-included

Batteries Included is a Kubernetes based software platform for database, ai, web, monitoring, and more.
https://www.batteriesincl.com/
Other
14 stars 0 forks source link

gitea: enabling sso doesn't disable registration #49

Open JTarasovic opened 1 year ago

JTarasovic commented 1 year ago

Looking at the docs it seems like these settings should be disabling user registration but that's not what I am seeing. The settings are getting rendered to app.ini correctly but don't seem to be having any effect.

elliottneilclark commented 1 year ago

https://github.com/go-gitea/gitea/issues/13606

It looks like gitea doesn't allow configuring those things :-/

JTarasovic commented 1 year ago

That's a bit different than what I was talking about. I don't really care if there's a login form that doesn't work. I wouldn't want users to be able to register themselves as gitea users outside of the SSO provider.

Seems like these settings from their docs would do it but that's not what I've been seeing:

        DISABLE_REGISTRATION=#{sso_enabled?}
        SHOW_REGISTRATION_BUTTON=#{!sso_enabled?}
        ALLOW_ONLY_EXTERNAL_REGISTRATION=#{sso_enabled?}
elliottneilclark commented 9 months ago

We should change the istio virtual service to route registration and login as redirects to oauth.