battleblow / openjdk-jdk11u

BSD port of OpenJDK 11
GNU General Public License v2.0
9 stars 8 forks source link

Incorrect libiconv linkage for libsplashscreen on FreeBSD #58

Closed battleblow closed 5 years ago

battleblow commented 5 years ago

On FreeBSD (11 at least), the built version of libsplashscreen.so isn't linked correctly with libiconv. This can be demonstrated by running the SwingSet2 demo:

> ./bin/java -jar ./demo/jfc/SwingSet2/SwingSet2.jar 
/usr/home/glewis/projects/java/jdk11/openjdk-jdk11u/build/bsd-x86_64-normal-server-release/images/jdk/lib/libsplashscreen.so: Undefined symbol "libiconv_open"

Note that this does run correctly with the version in the FreeBSD Ports system though, so it's just a matter of pulling in the correct iconv linkage from there. It's worth pulling that in though since the repo should build a correctly functioning JDK without needing outside patches.

battleblow commented 5 years ago

Committed a change to fix this. Will update the FreeBSD Port next time I roll a release.