battleblow / openjdk-jdk11u

BSD port of OpenJDK 11
GNU General Public License v2.0
9 stars 8 forks source link

<sys/user.h> was removed from NetBSD #90

Closed tnn2 closed 4 years ago

tnn2 commented 4 years ago

NetBSD no longer ships <sys/user.h>. See: http://mail-index.netbsd.org/tech-userlevel/2017/06/10/msg010630.html

I have verified that omitting inclusion of <sys/user.h> does not cause problem on older NetBSD releases.

battleblow commented 4 years ago

As a slightly tangential question, does this mean you've successfully compiled on NetBSD and have a working JDK?

tnn2 commented 4 years ago

Affirm, we have an openjdk11 package based on your repo in NetBSD pkgsrc now. There are some more patches in the pkgsrc tree but they aren't suitable to upstream (yet).

battleblow commented 4 years ago

Affirm, we have an openjdk11 package based on your repo in NetBSD pkgsrc now. There are some more patches in the pkgsrc tree but they aren't suitable to upstream (yet).

That's great! In general we're happy to upstream changes, so please do send pull requests once you're comfortable with the patches. There are a few changes that we've kept within the individual ports systems, but the goal is that out of the box the source can be built on recent releases of *BSD (given a suitable bootstrap and a supported architecture).

battleblow commented 4 years ago

We should probably take the conversation off of this, but I also wanted to ask if you have plans for the more recent releases (12, 13)? I know Kurt is currently planning on skipping those for the next long term release wrt OpenBSD. Just wondered if there are plans there for NetBSD.

tnn2 commented 4 years ago

Short answer: skip, but maybe not skip all the way until JDK 17. I don't think I will spend any time on it, at least not in near future.