search

battlecode / galaxy

MIT License
10 stars 3 forks source link

Add filtering to scrimmage list #18

Open n8kim1 opened 3 years ago

n8kim1 commented 3 years ago

By somewhat popular demand...

Ideas: filter by win or lose, score, maps, etc

Be careful with how this mixes with pagination, refreshing, changing-page, etc. Note that filtering after pagination is doomed. You should always filter before pagination. It's best if this filter occurs purely on backend. It is ok for the filter to occur on frontend, although for this to work ok, you'd have to fetch all results in frontend, which kinda defeats the point of pagination.

If full filtering is too hard, you could implement sorting as a sort of pseudo-pagination.

n8kim1 commented 2 years ago

note that sorting is in this issue: https://github.com/battlecode/galaxy/issues/58 and note that filtering allows for some good-enough searching