battlecode / galaxy

MIT License
10 stars 3 forks source link

Document the bug that caused #619; Improve comments to explain; Consider automated tests #731

Open n8kim1 opened 6 months ago

n8kim1 commented 6 months ago

Bug fix: https://github.com/battlecode/galaxy/pull/619/files Explainers abt bug: https://docs.djangoproject.com/en/4.2/topics/db/aggregation/#combining-multiple-aggregations, https://code.djangoproject.com/ticket/10060

This bug is painful to find, and also very difficult to understand. Also it breaks incredibly important things (esp final standings, prize money, etc) Also, documenting it should be quick, just a few minutes. I can do it during a break sometime. (I should anyways; it's something I need to know for other contexts...)