battlecode / galaxy

MIT License
10 stars 3 forks source link

Factories Loaders and Token Validity #746

Closed lowtorola closed 3 months ago

lowtorola commented 5 months ago

This PR does the following:

Need to test:

lowtorola commented 4 months ago

Not to toot my own horn but that commit is pretty epic some real late night success 😎

acrantel commented 4 months ago

Great job! I skimmed the code and it looks good, is there anything specific in this PR you'd want me to take a look at?

lowtorola commented 3 months ago

@acrantel I fixed the token validity issue!! Basically just added an await in App.tsx that blocks app loading until we verify that the token is valid. Lmk if you think this is fine (performance seemed just fine to me). I had to change the target in tsconfig.json to es2017 though, is that fine? 😎