search

batuhan / og-saltana

Abandon iteration for Minipage
https://www.minipagehq.com
1 stars 0 forks source link

move environment config getter to a backend agnostic scheme #4

Open batuhan opened 3 years ago

batuhan commented 3 years ago

Currently core uses Redis to get database, Elasticsearch and SMTP information for tenants (in our case different environments like staging, production, dev)

It's useful to dynamically change which ES server to search in or which SMTP to use for sending e-mails so it would not be wise to get rid of this feature. It needs to move to a backend agnostic key-value storage. We might use a flat JSON file locally and CloudFlare Worker for production. It needs to be able to make use of environment variables, somehow.

It's not a blocker for us to keep using Redis for now but I really like using Redis without persistent storage, it just makes life of a developer better to not rely on that. For PostgreSQL we have migrations and seeding, ElasticSearch indexes from the DB -- so that leaves Redis and odd child to manage.

batuhan commented 2 years ago

The description of the issue solves a problem we won't have. All variables should come from env variables to mitigate the need for a config storage.

Whatever orchestration software we are using should be responsible for the configs.