I think it is good that there's no FeedbackServiceManager.close() method, and
socket's life cycle is encapsulated in the class, if we are sure socket is
closed when done.
In the current version, socket.close() is called at the end of the getDevice()
method, but not in a finally block. Any exception, such as NPE, thrown in the
getDevice() method can cause memory leak which the caller will not be able to
close.
Would it be possible to move the close statement to a finally block?
Thanks,
Eric
Original issue reported on code.google.com by eric...@gmail.com on 7 Apr 2011 at 3:44
Original issue reported on code.google.com by
eric...@gmail.com
on 7 Apr 2011 at 3:44