this commit fixes that node does not crash with an invalid file descriptor on windows

baudehlo / node-fs-ext

Extras missing from node's fs module

MIT License

101 stars 45 forks source link

this commit fixes that node does not crash with an invalid file descriptor on windows #36

Closed simonhoss closed 9 years ago

baudehlo commented 9 years ago

Since I have no idea what this does I'm going to just merge it in.

bajtos commented 9 years ago

IMHO, this patch is turning of a critical assertion error thrown by the runtime. Like removing batteries from your fire alarm to stop it making annoying noise, when what you really should do is go and extinguish the fire in your house.

So the problem is not fixed. The file still won't be correctly locked on Windows, but now the user won't be told at all. Plus this patch disables the CRT assertions globally for all code running in the same process, which is IMO even more evil.

simonhoss commented 9 years ago

Thats correct. That this issue does not fix the problem, but for me it was more worse that nodejs crashes.