baudehlo / node-fs-ext

Extras missing from node's fs module
MIT License
101 stars 45 forks source link

port library to use NAN #37

Closed rlidwka closed 9 years ago

rlidwka commented 9 years ago

This patch should fix compatibility with node.js 0.11+ (issue https://github.com/baudehlo/node-fs-ext/issues/33).

Tested with joyent/node#master and node-forward/node#master.

I don't know C++ well, but... it compiles, so it should be good, right? :)

baudehlo commented 9 years ago

OMG I love this pull request :)

Going to run the tests, but otherwise, great!

ghost commented 9 years ago

No better way to check an item off your to-do list, is there? :smiley:

baudehlo commented 9 years ago

Tests all pass. Merged! Thanks a million - if you're ever in Toronto I owe you a beer or 12.