search

baudehlo / node-fs-ext

Extras missing from node's fs module
MIT License
101 stars 45 forks source link

compilation failed against new nan-1.6.1 #42

Closed pnemade closed 9 years ago

pnemade commented 9 years ago

In Fedora I am maintaining nodej-fs-ext package. I received notification about new tarball release. So, I created new package nodejs-fs-ext-0.4.3 and tried building it. But build failed against nan-1.6.1 module. See the failed https://kojipkgs.fedoraproject.org//work/tasks/1250/8881250/build.log

Can you fix fs-ext-0.4.3 to work against nan-1.6.1?

Thanks.

pnemade commented 9 years ago

looks like something changed from 1.4.1 to 1.5.0 nan module. See https://github.com/rvagg/nan/commit/216b79798d9a043f6961ae503aea5ba7146108e9

baudehlo commented 9 years ago

The build should be tied to Nan 1.4 according to package.json.

On Tue, Feb 10, 2015 at 1:21 AM, Parag Nemade notifications@github.com wrote:

looks like something changed from 1.4.1 to 1.5.0 nan module

— Reply to this email directly or view it on GitHub https://github.com/baudehlo/node-fs-ext/issues/42#issuecomment-73650517.

ggreer commented 9 years ago

@baudehlo is right that fs-ext 0.4.3 should be using nan 1.4. That said, I updated fs-ext to use nan 1.6 in #43. There just hasn't been a new release yet.

baudehlo commented 9 years ago

New release is out now.