Minimal patch to prevent breakage on node@11

baudehlo / node-fs-ext

Extras missing from node's fs module

MIT License

101 stars 45 forks source link

Closed mikesamuel closed 5 years ago

mikesamuel commented 5 years ago

Issue #76 explains that constants is not extensible in recent builds of node@11.

This changes the loop that adds constants from the C++ code to constants to be best effort.

mikesamuel commented 5 years ago

I haven't actually tested this, but adding

node_js
  - "stable"

to your .travis.yml under the existing versions should repeat the problem I was seeing. I can patch .travis.yml if you'd like.

baudehlo commented 5 years ago

Happy to accept the Travis change in another PR.