search

baudehlo / node-phantom-simple

Simple bridge to phantomjs for Node
MIT License
201 stars 70 forks source link

Fixes page.getPage to return a page object #137

Open Reewr opened 8 years ago

Reewr commented 8 years ago

Prior to this fix, the page object that would be returned would be missing functions and have properties that are unique to the PhantomJS page object. This fixes issue #131.

The function will, as it is suppose to, return a page object if it finds an object with the given name or it'll return null.

It needed its own special function as it needs to setup a new page, both in bridge.js and node-phantom-simple.js. Also added test to make sure it works correctly.

Reewr commented 8 years ago

Seems like the Travis CI build fails to retrieve SlimerJS.

Reewr commented 8 years ago

Any progress on this?

puzrin commented 8 years ago

I think more maintainers needed. I'm very busy with main project and currently use navit with electron adapter.

May be @awlayton / @johntitus / ... will agree?

PS. I can be back if 2.5 released with upgraded engine https://github.com/ariya/phantomjs/issues/14458

johntitus commented 8 years ago

Sorry, @awlayton is basically maintaining node-horseman himself these days as I don't have time.

On Wed, Aug 10, 2016 at 1:03 PM, Vitaly Puzrin notifications@github.com wrote:

I think more maintainers needed. I'm very busy with main project and currently use navit with electron adapter.

May be @awlayton https://github.com/awlayton / @johntitus https://github.com/johntitus / ... will agree?

PS. I can be back if 2.5 released with upgraded engine ariya/phantomjs#14458 https://github.com/ariya/phantomjs/issues/14458

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/baudehlo/node-phantom-simple/pull/137#issuecomment-238933381, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkB_jma0SOWuXPyxVMP8h1NajrAAM0Yks5qegRkgaJpZM4IyNSN .

awlayton commented 8 years ago

I currently do not have much more time for this sort of thing than what I am putting towards node-horseman. I would be open to possibly maintaining this as well at some point in the future, but I am not sure when that would be.

puzrin commented 8 years ago

Hm... https://github.com/baudehlo/node-phantom-simple/graphs/contributors i don't see potential "victims" in history stat :)

@Reewr may be you wish to become maintainer?

Reewr commented 8 years ago

Thanks for the offer, but due to an ongoing masters degree I'm afraid I won't have time to maintain other projects than my own.

Reewr commented 8 years ago

Updated to not cause conflicts with master (after new commits were added)