search

baudehlo / node-phantom-simple

Simple bridge to phantomjs for Node
MIT License
201 stars 70 forks source link

Added the ability to set the bridge path as an option. #145

Closed emmerich closed 8 years ago

emmerich commented 8 years ago

I recently ran into the use case where I needed to change the location of the bridge.js file (I am using the packager nexe which treats __dirname differently to other environments).

I have made a change to node-phantom-simple to allow manually declaring the bridge.js path. By default, it takes the same behaviour so this is a non-breaking change.

I understand my use-case is specific, and the problem I had is not caused by a bug in node-phantom-simple (rather a bug in nexe), but I thought I would submit this pull request and you can review whether it's something you would like to add regardless.

puzrin commented 8 years ago

It doesn't look good here. I think it's better to send patch to nexe.

emmerich commented 8 years ago

No problem. Was just opening the pull request to see if it's something you'd be interested in.