bug when ufw has no ipt_modules configured

[baudm]

Original issue 15 created by baudm on 2011-06-23T23:00:09.000Z:

What steps will reproduce the problem?

1. delete ipt_modules from ufw config either editing /etc/default/ufw IPT_MODULES=""

or from ufw-frontend preferences dialog, unchecking all modules

1. restart ufw-frontend

What is the expected output? What do you see instead? Traceback (most recent call last): File "/opt/eclipse/plugins/org.python.pydev.debug_2.1.0.2011052613/pysrc/pydevd.py", line 1141, in <module> debugger.run(setup['file'], None, None) File "/opt/eclipse/plugins/org.python.pydev.debug_2.1.0.2011052613/pysrc/pydevd.py", line 925, in run pydev_imports.execfile(file, globals, locals) #execute the script File "/root/workspace/ufw-frontends/ufw-gtk.py", line 10, in <module> main() File "/root/workspace/ufw-frontends/gfw/frontend_gtk.py", line 624, in main ui = GtkFrontend() File "/root/workspace/ufw-frontends/gfw/frontend_gtk.py", line 63, in init self._init_prefs_dialog() File "/root/workspace/ufw-frontends/gfw/frontend_gtk.py", line 84, in _init_prefs_dialog enable = ('nf_conntrack_pptp' in conf['ipt_modules']) KeyError: 'ipt_modules'

What version of the product are you using? On what operating system? http://code.google.com/p/ufw-frontends/downloads/detail?name=ufw-frontends-0.2.0.tar.gz Kubuntu 11.04 64

Please provide any additional information below.

if ufw has no ipt_modules configured, conf has no 'ipt_modules' key in File "/root/workspace/ufw-frontends/gfw/frontend_gtk.py", line 84, in _init_prefs_dialog

also in line 86

I solved checking for the key with this: enable = conf.has_key('ipt_modules') and ('nf_conntrack_pptp' in conf['ipt_modules'])

the same problem happens during saving preferences:

Traceback (most recent call last): File "/root/workspace/ufw-frontends/gfw/frontend_gtk.py", line 390, in on_prefs_dialog_show_activate self.ui.pptp_chkbox.get_active()) File "/root/workspace/ufw-frontends/gfw/frontend.py", line 76, in config_ipt_module modules = self.backend.defaults['ipt_modules'].split() KeyError: 'ipt_modules'

also same solution: modules = (self.backend.defaults['ipt_modules'].split() if self.backend.defaults.has_key('ipt_modules') else '')

[baudm]

Comment #1 originally posted by baudm on 2011-09-05T01:51:03.000Z:

<empty>

[baudm]

Comment #2 originally posted by baudm on 2011-09-06T06:25:13.000Z:

Fixed in r45a80f4110be