baudm / ufw-frontends

Graphical frontends for the Uncomplicated Firewall (UFW)
http://code.google.com/p/ufw-frontends/
GNU General Public License v3.0
40 stars 10 forks source link

ufw-gtk fails to run if LOG_FILE not found #18

Closed baudm closed 9 years ago

baudm commented 9 years ago

Original issue 17 created by baudm on 2011-09-10T13:15:11.000Z:

What steps will reproduce the problem?

  1. make sure LOG_FILE doesn't exist
  2. try to run ufw-gtk

What is the expected output? What do you see instead? ufw-gtk fails to run; error messages attached

What version of the product are you using? On what operating system? 0.3.0, Sabayon

Please provide any additional information below. Hello again. :) Systems which don't set-up logging to ufw.log (the log goes usually to /var/log/messages by default) are mostly affected. Proposed fix: if LOG_FILE doesn't exist, display message that for the function to work it is required that ufw (syslog) saves messages to ufw.log.

baudm commented 9 years ago

Comment #1 originally posted by baudm on 2011-09-10T13:52:58.000Z:

Hello. :)

You can check the fix here: https://github.com/baudm/ufw-frontends/tree/hotfix/check-for-ufw-log

What I did was use /var/log/messages in case /var/log/ufw.log didn't exist. This should work because the format of the log entries remain the same regardless of where they are stored.

I'll merge this branch (and maybe the 'hotfix/rules-export' branch too) to master and release 0.3.1 once this issue and issue 16 is fixed. :)

baudm commented 9 years ago

Comment #2 originally posted by baudm on 2011-09-10T19:02:05.000Z:

I generated and applied the patch as I'd done in issue 16.

Checked with logs saved to ufw.log and messages (ufw.log renamed, syslog configuration adjusted), everything is fine. Great work!

baudm commented 9 years ago

Comment #3 originally posted by baudm on 2011-09-10T19:05:28.000Z:

I forgot to add: checked also with both patches applied (for the two issues), all fine. :)

baudm commented 9 years ago

Comment #4 originally posted by baudm on 2011-09-11T02:42:20.000Z:

0.3.1 will be released very soon. Thanks for your help. :)