search

baudren / NoteOrganiser

Scientific Note Taking
MIT License
13 stars 6 forks source link

34 Button `Refresh` in Preview #50

Closed egolus closed 9 years ago

egolus commented 9 years ago

This adds a refresh button to the Preview page (right side, over the scroll area)

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 075c8fb on baudren:34-refreshButton into d499f74 on baudren:devel.

baudren commented 9 years ago

Thanks @egolus,

the placement of the button seems a bit awkward (problem related somehow to #49). This could be a good place to try a toolbar implementation, no? Do you want to take a go at it?

egolus commented 9 years ago

OK, I'll put a toolbar in Preview, so under the tabbar. If we like it, we can do the same for Editing

landscape-bot commented 9 years ago

Code Health Repository health increased by 0.06% when pulling 36afaf2 on 34-refreshButton into d499f74 on devel.

landscape-bot commented 9 years ago

Code Health Repository health increased by 0.06% when pulling be504d4 on 34-refreshButton into d499f74 on devel.

landscape-bot commented 9 years ago

Code Health Repository health increased by 0.09% when pulling aa3cec6 on 34-refreshButton into d499f74 on devel.

landscape-bot commented 9 years ago

Code Health Repository health increased by 0.07% when pulling cba8052 on 34-refreshButton into d499f74 on devel.

baudren commented 9 years ago

Travis failing to merge seems no problem - it seems git got confused over a trivial thing.

However - the implementation does not seem to work for me (Win 8.1). The toolbar is fixed to the three options Up, New N, New F, and whatever I switch tab to, stay there. I get repeatedly this error:

Traceback (most recent call last):
  File "noteorganiser/NoteOrganiser.py", line 271, in showActiveToolBar
    self.library.toolbar.setVisible(False)
AttributeError: 'Library' object has no attribute 'toolbar'

Surprisingly enough, the tests pass.

egolus commented 9 years ago

Aah, you're right, I forgot to change this to library.shelves.toolbar The tests don't need the toolbar to be visible to 'click' on it, it seems

landscape-bot commented 9 years ago

Code Health Repository health increased by 0.07% when pulling 0d890c0 on 34-refreshButton into d499f74 on devel.

egolus commented 9 years ago

This should fix the toolbar

baudren commented 9 years ago

It's looking good!

I will test tonight on linux to see how it looks there, then will merge it. Thank you!

landscape-bot commented 9 years ago

Code Health Repository health decreased by 0.01% when pulling 000a557 on 34-refreshButton into d499f74 on devel.

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 893ee00 on baudren:34-refreshButton into d499f74 on baudren:devel.

baudren commented 9 years ago

I think that the separator behaves strangely on my machine. There is a physical separation between the save and the one on the left, but no visual indication of it. Is there anything on your side? Do you find it visually clear enough?

egolus commented 9 years ago

separator there's a thin line, but I have to admit, it's very thin

egolus commented 9 years ago

separator2 we could use 3 separators to make it a bit stronger..

the other question is if it is strong enough when we use icons instead of text

baudren commented 9 years ago

Well, one or three, either is invisible on my linux setup. On win8.1, no problem. I will try to see if it is a known bug.

In terms of layout, I would put the Save and Reload to the left, rather than to the right.

I was also thinking that a more ribbon like appearance could work better, no? Having maybe a tab for each panel (Library, Editing, Preview), and the related options in these tabs?

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 90db336 on baudren:34-refreshButton into d499f74 on baudren:devel.

landscape-bot commented 9 years ago

Code Health Repository health increased by 0.18% when pulling 684b84c on 34-refreshButton into d499f74 on devel.

baudren commented 9 years ago

Since the functionnality is added, and working, I could merge this, right?

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling d0fb1c1 on baudren:34-refreshButton into d499f74 on baudren:devel.

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling f2bede7 on baudren:34-refreshButton into d499f74 on baudren:devel.