baudren / NoteOrganiser

Scientific Note Taking
MIT License
13 stars 6 forks source link

reenable shortcuts for Toolbar items #77

Closed egolus closed 8 years ago

egolus commented 8 years ago

(#74)

Available shortcuts:

landscape-bot commented 8 years ago

Code Health Code quality remained the same when pulling 2a181d1 on baudren:74-Shortcuts into bafe9e5 on baudren:devel.

egolus commented 8 years ago

I added custom Actions for the tabs. I haven't found a way to add custom shortcuts directly to the tabs (what is strange in my opinion).

can I combine the methods setActiveTab... to one method? I would have to use a custom slot @Slot(QtGui.QWidget) and somehow use the widget in the connect-call, right?

EDIT: OK, I found a way by using the sender of the signal

baudren commented 8 years ago

Nice work. What about ctrl+F for new folder in the library tab? And ctrl+T for exterior editor?

egolus commented 8 years ago

Ctrl+F is normally search but ok, I think it's still better than Ctrl+R. Ctrl+T is normally open new tab, but as we don't have a feature like this I like it, too

Edit: aaah, I remember why I didn't use Ctrl+F: As I want to have the underlined character as a shortcut indicator, I tried to have the same shortcut both with Ctrl and Alt. And Alt+F is allready used for the &File-menu

landscape-bot commented 8 years ago

Code Health Repository health decreased by 0.41% when pulling 3bd035d on 74-Shortcuts into bafe9e5 on devel.

baudren commented 8 years ago

Works nicely, and the tests run fine. Can I merge it?

egolus commented 8 years ago

It still bugs me that we can't test the shortcuts, but yes, I think, I'm finished