search

baudren / NoteOrganiser

Scientific Note Taking
MIT License
13 stars 6 forks source link

moved log file to .noteorganiser for #78 #79

Closed baudren closed 8 years ago

baudren commented 8 years ago

This should suffice for solving #78, right?

egolus commented 8 years ago

what if the user has moved the notebook-folder?

baudren commented 8 years ago

Does the log file really has to follow this? I wondered, too, and thought that we could still use .noteorganiser as a storage, even though the actual notebooks are not stored there. The reason why I did not make it follow the storage was that the configuration initialisation requires the logger.. so I do not have this information while creating it.

I am not sure that trying to decouple these things would bring so much, but if you think that yes, I could do it.

egolus commented 8 years ago

yes, I realized this, too. If it's not that easy to decouple, it's no problem I think. I think a new user that gets the popup to set the notebook-folder may think it's a bug if the log still gets put into this directory, but I think it's OK

landscape-bot commented 8 years ago

Code Health Code quality remained the same when pulling a5b6107 on baudren:78-log into b7622f7 on baudren:devel.