search

baudren / NoteOrganiser

Scientific Note Taking
MIT License
13 stars 6 forks source link

insert image #95

Closed baudren closed 7 years ago

baudren commented 7 years ago

Since the work by Egolus was on his fork, I could not modify the PR, so here is a new PR containing his work plus some tests.

baudren commented 7 years ago

I would suggest to merge this, and open a bug report for trying to fix the bug that breaks, even though it does not break locally.

baudren commented 7 years ago

Ah, I just realized: don't we want to add this functionality also from within the post creation? Because you probably think about an image at that time, not once the post is created. This should not require much more work, right?

egolus commented 7 years ago

You're right, I'll look into reusing the method with a new action inside the new-post form

baudren commented 7 years ago

This looks good. I am merging this now, thanks for the work!