search

baudren / montepython_public

Public repository for the Monte Python Code
MIT License
65 stars 115 forks source link

CosmoHammer needs update #105

Open carlosggarcia opened 6 years ago

carlosggarcia commented 6 years ago

CosmoHammer sampling method does not work at this moment (problems importing modules (#47) , storing derived parameters (#36, but not only) , reading user input CH options). I have updated cosmo_hammer.py to make it work.

I cannot make a pull request since I am forking @miguelzuma montepython_public fork, but changes can be seen in https://github.com/miguelzuma/montepython_zuma/pull/7

carlosggarcia commented 6 years ago

I solved a minor bug. Now analyzing the CH output creates the MontePython chain with -loglkl instead of the loglkl, used by CH. https://github.com/miguelzuma/montepython_zuma/pull/8/commits/16085a36b8f51a4ec5a93ed4a511936f8d7f474d

A note about the derived parameters. They are not ordered. As CH returns a dictionary, when reading its itervalues, they do not follow the same order as expected by MP.

carlosggarcia commented 6 years ago

There continued being errors: derived parameters were not stored correctly. It is fixed with https://github.com/miguelzuma/montepython_zuma/pull/9/commits/81788c56e89749f7bff0831c5b2dffe5c8d7da75 and https://github.com/miguelzuma/montepython_zuma/pull/9/commits/bbcedf87904ecfc7033e4fbbf866ac55109dbdd6.

In order to work more easily with the output, I decided to sort the derived parameters columns alphabetically: https://github.com/miguelzuma/montepython_zuma/pull/9/commits/f8b41424040b691acb22975a3939737b56b1a3eb