search

bauerdavid / napari-bbox

BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

3D bounding boxes not displaying correctly #16

Closed grahamross123 closed 3 months ago

grahamross123 commented 7 months ago

Describe the bug Hi, I've been experiencing another minor issue. After I draw a 3d bounding box in the 2d viewer, the bounding box disappears if I change the z-slice. If I switch the viewer to 3d mode and back to 2d, the bounding box displays over all slices as expected.

Steps to reproduce Using the napari-bbox plugin, create a new layer with ndims=3. After drawing the bounding box, adjust the z-slice a few steps and the box disappears. Switch to 3D view then back to 2D, and the box displays correctly. (Alternatively, the issue is fixed by transposing or switching the axes).

I'm using napari version 0.4.18.

Any thoughts on this?

Thanks, Graham

bauerdavid commented 7 months ago

Hey, yeah, I remember that I encountered this issue. Unfortunately, I couldn't find out what's the cause of this issue. I'm quite busy nowadays, but I'll try to look into the problem soon.

Best, David

grahamross123 commented 7 months ago

Thanks!

grahamross123 commented 3 months ago

Hi @bauerdavid, I've found the source of this issue. When drawing bounding boxes, the transform function is called which updates the data points correctly but does not update the bounding box slice key. The slice key then stays at its initial value until the data method is called.

I can create a pull request with the fix for this if I have push access to the repo.

Thanks, Graham

bauerdavid commented 3 months ago

Great, thanks for looking into it! You don't actually need push access, just create a fork from the repo, and edit there. You can find some more info here.

bauerdavid commented 3 months ago

Solved in #17