search

bauerdavid / napari-bbox

BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Bounding boxes not displaying at correct z-heights #18

Open grahamross123 opened 3 months ago

grahamross123 commented 3 months ago

Describe the bug When using a z scale factor in Napari, the bounding boxes do not display at the correct z slices. e.g. if a bounding box ranges from z1=0.3 to z2=1.3, it will display when the viewer is in the ranges z1=0.5 to z2=1.5.

Expected behavior Bounding boxes should display at the correct z slices regardless of the scaling factor used.

grahamross123 commented 3 months ago

Hi @bauerdavid,

I've experienced another minor issue. This can be fixed by keeping the bounding box slice key as a float instead of an integer here as the slices can include decimals when a scaling factor is used. If this is desired, I can submit the pull request.

Thanks, Graham

bauerdavid commented 2 months ago

Hey @grahamross123, please do so! I just created a new release, but I will include it in the next one Thanks!

psobolewskiPhD commented 2 weeks ago

I've also run into this, so gentle bump @bauerdavid ❤️