search

bauerdavid / napari-nD-annotator

BSD 3-Clause "New" or "Revised" License
28 stars 1 forks source link

Package is using `PyQt5` imports instead of `qtpy` #39

Closed goanpeca closed 1 year ago

goanpeca commented 1 year ago

Hello team!

The plugin documentation for napari has a set of best practices for developers, which includes a clause recommending not to depend directly on PyQt5 or PySide2 to allow end-users to choose their bindings freely. More details here.

The files using PyQt5 instead of qtpy -> https://github.com/bauerdavid/napari-nD-annotator/search?q=pyqt5

Is there a reason you need PyQt5 explicitly? Could these imports be updated to use qtpy for the next release?

Thanks!

bauerdavid commented 1 year ago

This is an error indeed, qtpy should be used. Thanks for pointing that out! Fixed in 128cd09b38afce3e041694aa12554f9596eaf1c0.

goanpeca commented 1 year ago

Thanks for the fix! :)