Android Share Sheet intent

bauerj / paperless_app

An Android/iOS app for Paperless

https://play.google.com/store/apps/details?id=eu.bauerj.paperless_app

GNU General Public License v3.0

524 stars 45 forks source link

Android Share Sheet intent #26

Closed qcasey closed 3 years ago

qcasey commented 3 years ago

Okay this is my initial draft of the share sheet intent.

Right now this:

Adds Paperless to the Android share menu.
Uploads shared pdfs + images similarly to the inbuilt scanning feature.
Sets the shareAmount when it receives any # of items, which uses the same card popup as scanAmount to inform the user of upload progress. That popup now also displays the correct number documents (scans or shares).

Would you like anything different / extra in the UI? My paperless_share for example, throws a Toast then pops back to the previous app (the one that shared the document). Up to you.

Open to any other changes of course

qcasey commented 3 years ago

Thank you!

I put back .plural, instead modifying only the howMany argument. Hopefully that works alright, I'm not sure how to test i18n.

No rush of course, whenever you've got time :smiley:

bauerj commented 3 years ago

Thank you too.

That looks better now. Yes, currently there is no way of testing the i18n functionality without change the system locale.

There are so many awesome tools around Flutter around UI testing but I haven't really had time to look into it. So my current approach is to run the app manually and see if it works. Of course I probably forget about half the things this way. This is why I didn't spot the issue with uploading documents to Paperless NG.

But anyway, I will do my "better than nothing" test routine tomorrow and report back to you!

qcasey commented 3 years ago

That's what I do anyway, hah. Sure sounds good.

bauerj commented 3 years ago

Well, this worked perfectly :+1:

With regards to your open question:

Would you like anything different / extra in the UI? My paperless_share for example, throws a Toast then pops back to the previous app (the one that shared the document). Up to you.

I don't fell strongly towards either option. It might be good to continue back to the previous app if you had other documents to upload or whatever. On the other hand, it might be nice to edit the document details once it's been processed (and that's possible with the app...) and it would be cumbersome to do that if the app closes automatically.

Maybe a better option would be to close the app and show a system notification to track the upload progress. But improvements can be done later so I'm merging this feature now. Thanks a lot!

jonaswinkler commented 3 years ago

This is exciting. I did include a reference to paperless share in the documentation on adding documents and in the readme. I suppose I can replace that with references to this now?

qcasey commented 3 years ago

I intend to maintain paperless_share at least for myself, but this app here is definitely a fuller experience. I'd emphasize it over mine, whatever that entails.