search

bauerji / flask-pydantic

flask extension for integration with the awesome pydantic package
MIT License
368 stars 58 forks source link

Add kwargs parsing #13

Closed adriencaccia closed 4 years ago

adriencaccia commented 4 years ago

This PR is implementing solution 2 of #12.

@bauerji like I said in the issue I already implemented a solution, so this is the PR.

I am, of course, still open to discuss the different solutions !

bauerji commented 4 years ago

It looks neat, thank You. Could You please remove .vscode directory and also modify README.md file to include feature You created?

adriencaccia commented 4 years ago

It looks neat, thank You. Could You please remove .vscode directory and also modify README.md file to include feature You created?

No problem for the README.md Do you mind if instead I add .vscode to .gitignore ?

bauerji commented 4 years ago

It looks neat, thank You. Could You please remove .vscode directory and also modify README.md file to include feature You created?

No problem for the README.md Do you mind if instead I add .vscode to .gitignore ?

Of course, add it to .gitignore. The directory should be deleted as well.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication