search

bauerji / flask-pydantic

flask extension for integration with the awesome pydantic package
MIT License
368 stars 58 forks source link

Support Pydantic v2 #75

Closed jkseppan closed 10 months ago

jkseppan commented 1 year ago

Fixes #74

ronyriachy commented 1 year ago

When will this be merged?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Matvii-Boichenko commented 1 year ago

@adeadman sorry to disturb you. It seems this PR with kinda critical fix is stuck in this state for more than a month. Could you please provide info about the cause? It seems workflow just stopped. Is there any way to finish it or some info when it may happen automatically?

adeadman commented 1 year ago

@adeadman sorry to disturb you. It seems this PR with kinda critical fix is stuck in this state for more than a month. Could you please provide info about the cause? It seems workflow just stopped. Is there any way to finish it or some info when it may happen automatically?

I am not the maintainer of this library. I think you mean @bauerji, who would need to look at the build statuses and approve the merge. Looking at their Github profile, they have not been active for a number of months and I haven't found any more publicly available information about the status of this project or the maintainer. Hope this helps

jim-schwoebel commented 1 year ago

Bumping this as well! Pydantic v2 support would be great.

mjgp2 commented 1 year ago

I think this may end up needing to be forked, the owner seems MIA from Github unfortunately, hopefully he is OK.

amjed-ali-k commented 11 months ago

@bauerji Kindly look into this

jim-schwoebel commented 11 months ago

Anyone down to fork and maintain in public pypi?

Maybe flask-pydantic2 or something as a name

bauerji commented 11 months ago

Hey all, thank you for your contribution.

Sadly, I've had no time for this project recently.

Is there anyone who would be willing to take over? I think it would be better to continue in this rather than forking etc.

amjed-ali-k commented 11 months ago

Kindly merge this and release.

bauerji commented 11 months ago

@jkseppan, I am sorry for such a late response. Thank you for your contribution.

Could you please adjust the tests a bit to pass? It would be nice if we could get rid of the pydantic version in error messages, so that we don't have to adjust it every time.

See the test results above for more details.

jkseppan commented 11 months ago

Looks like there are a few reasons for the test failures. I can make the tests pass locally by downgrading flask to 2.3.3, pydantic to 2.1 and pytest-flask to 1.2.0. The pydantic version number problem should be easy enough to fix, no idea yet about flask 3.0 changes.

bauerji commented 11 months ago

@jkseppan please, check https://github.com/bauerji/flask-pydantic/pull/77 there are some changes that might help you with that

sonarcloud[bot] commented 11 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

jkseppan commented 11 months ago

@bauerji The other checks are passing, I don't know what's up with the two that are stuck.

bauerji commented 10 months ago

@jkseppan Thank you very much!

Released in a new version 0.12.0 🎉