bauerji / flask-pydantic

flask extension for integration with the awesome pydantic package
MIT License
352 stars 56 forks source link

support for pydantic v2 and flask 3.0.0 and pytest-flask 1.3.0 #77

Closed yctomwang closed 8 months ago

yctomwang commented 10 months ago

updated unit test and base code to support for pydantic v2.x along with flask 3.0.0 and pytest-flask 1.3.0

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jim-schwoebel commented 8 months ago

Thanks for the PR, great to see more work in this area.

yctomwang commented 8 months ago

@bauerji Hi bauerji, I am a huge fan of the flask-pydantic package you have created and we even use this package at our company(Australia's second largest telco!), is there any chance that you could review this PR and merge it? It would also be nice if you could add me as a modifier to this repo so I could continue contribute to it! Many Thanks Thomas

yctomwang commented 8 months ago

@jim-schwoebel thanks man for your kind words!

bauerji commented 8 months ago

Hello @yctomwang,

Thank you for your contribution!

Could you please consult the test results and adjust the code for them to pass? 🙏

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

yctomwang commented 8 months ago

@bauerji all fixed however it looks like there are still 2 builds pending the 3.8 and 3.7 and btw thank you once again for making me a collaborator :)

bauerji commented 8 months ago

@yctomwang I am sorry, In the end I decided to merge https://github.com/bauerji/flask-pydantic/pull/75.

Please, adjust this PR if you still want to merge this

yctomwang commented 8 months ago

@bauerji I think PR 75 solves the pydantic 2 and flask 3.0 issue all together so I will close this PR.