bauerji / flask-pydantic

flask extension for integration with the awesome pydantic package
MIT License
352 stars 56 forks source link

Fix CI on macOS runners #94

Closed Merinorus closed 1 month ago

Merinorus commented 2 months ago

Following the CI failing on PR #92.

This PR contains the following:

Fix #93

Merinorus commented 2 months ago

I guess we need a repo administrator to change which build steps are mandatory, otherwise, we are stuck :)

yctomwang commented 2 months ago

@Merinorus yes, despite been a collabroator, i cant change the build step :( I think we need Jiri the owner

yctomwang commented 2 months ago

@bauerji Hey Jiri in order to move forward, we really need to get rid of the the build(3.7) and build(3.8) to be able to merge the code, otherwise we wont be able to merge any code as the merge pull request is grey due to pending for build3.7 and build3.8. Would be extremely nice if you could remove them!

bauerji commented 2 months ago

@bauerji Hey Jiri in order to move forward, we really need to get rid of the the build(3.7) and build(3.8) to be able to merge the code, otherwise we wont be able to merge any code as the merge pull request is grey due to pending for build3.7 and build3.8. Would be extremely nice if you could remove them!

Hey, could you please elaborate a bit on what do you think must be done by me? 🙏 Afaik the configuration of builds is defined in tests.yaml which can be changed normally by PRs. Or is there something else in the project configuration?

Merinorus commented 2 months ago

Hi @bauerji , I think the branch protection rules should be changed (repo settings -> Branches).

At Require status checks to pass before merging, you can require all the following status checks:

image

The other checks (build 3.7, build 3.8) should not be required, as from this PR the project does not have these checks anymore.

Note: the checks are the same, but their name have changed so GitHub has lost track.

bauerji commented 2 months ago

@Merinorus, great, thank you for the explanation. Done!