search

baugarten / CS169-Group-11

OneProsper website, crowdfunding for rural farmers in India
1 stars 2 forks source link

User dashboard picture upload #10

Closed ducky64 closed 12 years ago

ducky64 commented 12 years ago

Picture upload is working, along with user dashboard. Pictures currently upload as binary into database - not recommended practice, but probably the cleanest option given the circumstances.

ducky64 commented 12 years ago

I was going to say that this should be its own controller, since it's not a generic user operation, but only applies to current_user. It also references things like donations and campaigns, which eventually might be their own objects.

As for keeping track of previous photos, that seems unnecessary, and takes up space.

The UI improvements would probably be done in the next iteration, and have their own user stories. Adding a /dashboard/edit would probably also be a good idea - next iteration too?

The idea for PhotoController was to decouple photos, so a migration to AWS S3 or their own servers would only require modification in one class. Photo is polymorphic, so you should be able to make them farmer photos too.

ducky64 commented 12 years ago

Could we also require first and last names during registration? Assuming this information exists would make this (and a lot of other things) easier. And a screen name.

mqphan commented 12 years ago

I think we can ask for first and last name, but not displaying them publicly anywhere in the app. Real first and last name can be used in thank you e-mail if we can implement it. In my opinion, a screen name is almost a must because people dont want to publish their real name. We can use the screen name for later stuff like top 10 donors.

baugarten commented 12 years ago

Agreed on username. Not sure about first and last name...

Can we try to comment inline where applicable.. its easier to tie comments to code changes that way.

I understand why you have PhotoController now.... wow thats horrible (not on your part, I mean that we have to do that).... thats going to be super slow for static content

chungfai commented 12 years ago

we can add nickname field, maybe something dont want to show their real name.

On Sat, Oct 20, 2012 at 10:22 PM, Ben Augarten notifications@github.comwrote:

Agreed on username. Not sure about first and last name...

Can we try to comment inline where applicable.. its easier to tie comments to code changes that way.

I understand why you have PhotoController now.... wow thats horrible (not on your part, I mean that we have to do that).... thats going to be super slow for static content

— Reply to this email directly or view it on GitHubhttps://github.com/baugarten/CS169-Group-11/pull/10#issuecomment-9639921.