search

baugarten / CS169-Group-11

OneProsper website, crowdfunding for rural farmers in India
1 stars 2 forks source link

add title to page #37

Closed mqphan closed 11 years ago

mqphan commented 11 years ago
  1. Add tab-title to all pages
  2. Place a link to project index page on the nav bar
  3. There are 2 failed tests in dashboard.feature: "Projects to fund" and "Invitations to fund":
    • Projects to fund fails because I delete link to project index page on dashboard. Nav bar already has a link to project index page, no need for the same link again on dashboard.
    • I delete the link of "Invitations to fund" since I dont think we are working on this feature. It does not look nice to have unfinished stuff.

Comment?

chungfai commented 11 years ago
  1. What is tab title?
  2. Very good idea
  3. as long as the tests did not involve the controller, i think you can delete it..
mqphan commented 11 years ago

tab title is the title that appear at the top of the browser window when you are looking at a specific page. Before we had "My App" for every page

mqphan commented 11 years ago

Also, I fix the red bar in the sign up page in this branch

baugarten commented 11 years ago

LGTM, merge away

mqphan commented 11 years ago

what is LGTM, Ben? Ok to merge?

chungfai commented 11 years ago

LOOK GOOD TO ME ,lol, i just googled it....

baugarten commented 11 years ago

lol, yeah