search

baugarten / CS169-Group-11

OneProsper website, crowdfunding for rural farmers in India
1 stars 2 forks source link

Fixed #51

Closed baugarten closed 11 years ago

baugarten commented 11 years ago

Fixed bug for multiple videos/campaign friends

ducky64 commented 11 years ago

Video looks fixed. See a red box on the Add Friends stage though, even when there is no error.

ducky64 commented 11 years ago

Also, is support for anything other than YouTube videos planned? If not, we should enforce the URL of the video; otherwise we need better support - perhaps instead of the YouTube embedded player, you provide a link to the external video.

baugarten commented 11 years ago

@ducky64 See a red box on the Add Friends stage though, even when there is no error.

I can't replicate this -- can you screenshot?

ducky64 commented 11 years ago

http://imgur.com/KXgLb See red box on top of page.

baugarten commented 11 years ago

Interesting... doesn't render on chrome.

I'll look into it before merging

baugarten commented 11 years ago

Fixed

ducky64 commented 11 years ago

I can't add friends anymore...

ducky64 commented 11 years ago

Seems like it will fail silently - when you try to click 'next' with invalid data, it just silently fails. Should at least tell you what's wrong.

baugarten commented 11 years ago

Working now

chungfai commented 11 years ago

looks good the interface. I think can merge

but found out two other bugs,, broken confirm link?
1.tried to create a new campaign , typed in template, and then hit send. but it just shows http://localhost:3000/campaigns/6/confirm_watched?friend=

2."when I edit the template and add the " " into the template, but when I click send, the link doesnt shows up/?? seems edit template broken, it doesnt do the updates for either the title or the content

chungfai commented 11 years ago

actually it's saved after the edit, but just didnt shows up on the email

baugarten commented 11 years ago

try pulling again