search

bauglir / Kroki.jl

Supports creating a variety of diagrams through the https://kroki.io service.
https://bauglir.github.io/Kroki.jl/stable
MIT License
81 stars 3 forks source link

Reorder `showable` methods to fix test coverage #26

Closed bauglir closed 2 years ago

bauglir commented 2 years ago

Defining the MIME"image/svg+xml" method after the showable method parameterized by MIME type ensures the way SUPPORTED_TEXT_PLAIN_SHOW_MIME_TYPES is calculated is covered.

This seems like an arbitrary effect but is reproducible deterministically by moving the method definitions around.

codecov[bot] commented 2 years ago

Codecov Report

Merging #26 (7d6a077) into development (fdfb5d9) will not change coverage. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development      #26   +/-   ##
============================================
  Coverage        99.09%   99.09%           
============================================
  Files                4        4           
  Lines              111      111           
============================================
  Hits               110      110           
  Misses               1        1
Impacted Files Coverage Δ
src/Kroki.jl 96.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdfb5d9...7d6a077. Read the comment docs.

bauglir commented 2 years ago

It appears this was a fix that happened to work for getting back to full coverage locally, but not in general (neither on Codecov nor Coveralls).