Use PhantomJS from Master branch

bauhausjs / phantom-html2pdf

Node module to generate PDFs from HTML via PhantomJS

MIT License

112 stars 47 forks source link

Use PhantomJS from Master branch #22

Closed haydenbleasel closed 8 years ago

haydenbleasel commented 8 years ago

TL;DR links aren't clickable at the moment, it's scheduled for the 2.1 release but I need this immediately. It's been merged into master, see: https://github.com/ariya/phantomjs/issues/10196

haydenbleasel commented 8 years ago

Not sure if this is a side effect but npm installing is really slow...

dustin-H commented 8 years ago

Hi @haydenbleasel,

thanks for this information.

However I will not use an unreleased and eventually unstable version of phantomJS in this lib.

You can use your fork of this repo as dependency, if you need it. (git://github.com//haydenbleasel/phantom-html2pdf.git)

Otherwise you need to wait for the next phantomJS release. This lib is using the latest version, so it will update without any changes.

Cheers Dustin