search

bauhausjs / phantom-html2pdf

Node module to generate PDFs from HTML via PhantomJS
MIT License
112 stars 47 forks source link

Fix regression in 2.0.1 (sorry) #26

Closed rossille closed 8 years ago

rossille commented 8 years ago

Hi @dustin-H and really sorry but I introduced a regression in my last pull request.

I realised this when running the test suite of my projet with version 2.0.1 of phantom-html2pdf

The problem is that i forgot to rename the package in lib/phantom-html2pdf.js

This PR fixes the issue and I think it's not completely good (although a couple of automated tests wouldn't hurt). If you're interested, I can make a PR that adds automated tests...

dustin-H commented 8 years ago

Ah, thanks for that... no problem! We are human, making mistakes :wink:

I also just tried to build it and forgot to test anything.

Contribution is very welcome! Since I am not the creator of this lib I know the code not that good. So if you like to improve something and PR, I am very happy :beers:

dustin-H commented 8 years ago

@rossille Just published v2.0.2