Closed OccamsCat closed 8 years ago
Hi, @dustin-H,
Thanks for the quick review! I added the change you requested (except I'm just setting it to an empty string, because that way it's easier to check, whether this option exists inside of phantom-script.js) and also made a modification, which should make this feature a non-breaking change.
E.g. now, if a runningsArgs
option is not passed, then the regular runnings file will still work, (without it having to be wrapped in a function). But perhaps it's still a good idea to increment the version, that is obviously up to you.
@OccamsCat Thanks for your work... I will merge and publish this weekend.
Why did you close @OccamsCat ? I cannot merge when it is closed.
Oops, I'm sorry, that was unintentional. (I was writing a comment and clicked the wrong button on accident (:
Thanks for the quick communication. Looking forward to the new release!
The
runningsArgs
option passes an object of parameters to the runnings file, thereby allowing the creation of headers and footers containing variables passed in from elsewhere in the app.In order for the runnings file to accept this argument, the returned object needs to be wrapped in a function with one parameter like so:
The above example assumes that the
runningsArgs
option was passed an object, containing the propertyuserName
. E.g.: