bauhausjs / phantom-html2pdf

Node module to generate PDFs from HTML via PhantomJS
MIT License
112 stars 47 forks source link

using synchronous fs Close #48

Closed SimonMARTIN87 closed 7 years ago

SimonMARTIN87 commented 7 years ago

Fixing Issue #47

"npm test" results : with fs.close(): phantom-html2pdf.js Simple end to end test (node:13964) DeprecationWarning: Calling an asynchronous function without callback is deprecated. (node:13964) DeprecationWarning: Calling an asynchronous function without callback is deprecated. ✓ Should generate a PDF file without crashing (4101ms)

With fs.closeSync(): phantom-html2pdf.js Simple end to end test ✓ Should generate a PDF file without crashing (1155ms)

it's even faster ;)

dustin-H commented 7 years ago

Thank you @SimonMARTIN87 !