search

baumblatt / capacitor-firebase-auth

Capacitor Firebase Authentication Plugin
MIT License
261 stars 129 forks source link

internal use of @capacitor-community/apple-sign-in #142

Open mesqueeb opened 3 years ago

mesqueeb commented 3 years ago

The package: https://github.com/capacitor-community/apple-sign-in

Now has web and iOS support.

Would it be smart for baumblatt/capacitor-firebase-auth to use this package as a dependency in order to not have to re-invent the wheel?

I'm just suggesting because it says:

Apple + Web: 🧠 - Thinking about, date to be defined

lincolnthree commented 3 years ago

So, there's really no need to bring in another plugin (which wouldn't be using firebase, kind the point of this plugin IMO) when Firebase already does all this work for us. I've actually just updated the plugin in my fork to support Apple on Android, Web, and iOS, including the web wrappers to support the firebase/auth browser integration.

But I like the way you think ;)

Here's my fork that has all platforms/integrations working (except email -- I even took a stab at web/phone, but have not tested it yet). As you can see, it uses the same firebase APIs the other plugins use.

https://github.com/lincolnthree/capacitor-firebase-auth

You can try it by including this repository in your package.json directly instead of specifying a version:

"dependencies": {
    "capacitor-firebase-auth": "lincolnthree/capacitor-firebase-auth"
}
lincolnthree commented 3 years ago

Pull request: https://github.com/baumblatt/capacitor-firebase-auth/pull/146