Library update - Githubissues

baumblatt / capacitor-firebase-auth

Capacitor Firebase Authentication Plugin

MIT License

261 stars 129 forks source link

Library update #181

Open alexookah opened 3 years ago

alexookah commented 3 years ago

I see that this library now supports capacitor 3.0 But a lot of deprecations have still to be handled in iOS and android. Should we create some PL or create a fork to fix the deprecations?

baumblatt commented 3 years ago

Hello @alexookah

Please let me know whatever was needed to solve this deprecations, we have two ways:

1) Create a PR under the branch next. 2) List here whats changes was needed.

Looking forward to hearing from you.

ps: Please, don’t forget the use the next branch to send a PR.

Best regards.

alexookah commented 3 years ago

Hello @baumblatt,

Just made A PL which resolves the deprecation for the iOS Plugin which communicates with the new 3.0 Capacitor plugin. Some more stuff that need to be done:

The android plugin needs to be checked if it needs also to be updated.
The GoogleProviderHandler.swift does not work. Because Google has updated the library and needs some refactor.
The xcode project does not contain AppleProviderHandler.swift, in order to build it would be nice to have the xcode project ready to run.
I noticed that the podfile.lock and package.lock is quite old. Maybe they should be updated.

baumblatt commented 3 years ago

Hi @alexookah ,

Your PR was merged, and released in version 3.1.2-rc.0 with some package.json reviews.

But after I read this, I add AppleProviderHandler.swift to the project and run pod install.

Everything still working here, event Google SignIn.

The final work is released in version 3.1.2-rc.1.

Best regards.

alexookah commented 3 years ago

Hi @baumblatt, Thanks for reviewing my PR and merging it. About the Google SignIn you have to run pod update in order to get the latest google sign in version.

Look at the following screenshot:

Google sign has been updated and I can’t archive the app currently.

mishrasatyam commented 3 years ago

Could you also update firebase to latest version 9 beta in the next version of this package if not in stable version. Currently this project does not work with vite

alexookah commented 3 years ago

@baumblatt Just made a PR fixing the google sign in update.

alexookah commented 3 years ago

@baumblatt Thanks for the MR about googleSignIn. Last step is to resolve the android capacitor 3.0 changes.

https://capacitorjs.com/docs/updating/plugins/3-0#use-the-new-capacitorplugin-annotation

I tried to check the changes but I really am not sure how to resolve some changes (I am an iOS developer). Can you check them out to close this issue?