search

baumblatt / capacitor-firebase-auth

Capacitor Firebase Authentication Plugin
MIT License
261 stars 129 forks source link

fix: Return full name with apple sign in #194

Open TylerAHolden opened 2 years ago

TylerAHolden commented 2 years ago

Fixes #191 by adding the fullName object to the firebase User object that gets returned from the apple sign in method.

moblizeitllc commented 2 years ago

is this fixed?

TylerAHolden commented 2 years ago

is this fixed?

Yea this fixes it for me but just be wary of how it behaves... You'll get fullName back with the firebase.User object ONLY the first time you authenticate with apple. After that, Apple never sends you the name again.

moblizeitllc commented 2 years ago

just updating the capacitor plugin should get me the latest code correct? if apple does it just once then what would be the best way to verify this?

mauriceackel commented 2 years ago

Hi everyone: I'm currently also facing the issue that the display name is not provided when signing in with Apple. I checked the code of this PR and IMO this is rather a workaround than a fix and I don't know whether that should be included in the library. I don't want to offend anyone here and if this workaround fixes the issue in your use case that's great! I just think the issue should be fixed in the Firebase SDK instead of having a special workaround for only the Apple signin logic in this plugin.

TylerAHolden commented 2 years ago

Yea this is kind of a work-around but given that it's a required feature of this library in order to submit to the iOS store it seems like reason enough to add a temporary patch. I haven't seen any movement on the Firebases SDK so it doesn't seem like waiting for them to add that feature is the best move. @mauriceackel nonetheless, I added the PR so others like yourself have something to work off of even if it doesn't get merged.

JoelAH commented 2 years ago

Can this be merged in & released? It impacts App submission

parambidja commented 2 years ago

Can this be merged? I'm having the same issue

leonardoeckh commented 1 year ago

Hey Tyler how i can use your branch? I already tried to install yarn add git+https://github.com/TylerAHolden/capacitor-firebase-auth.git but it doesn't recognize the module when importing