Fix version 2.2.1 not compiling: Update to the new Capacitor Config Class

baumblatt / capacitor-firebase-auth

Capacitor Firebase Authentication Plugin

MIT License

261 stars 129 forks source link

Fix version 2.2.1 not compiling: Update to the new Capacitor Config Class #95

Closed sergiomilici closed 4 years ago

sergiomilici commented 4 years ago

Current capacitor version 2.2.1 deprecated Config class replacing it with CapConfig making the project not compiling.

This fix changes the usages of Config in replacement of the new CapConfig class.

baumblatt commented 4 years ago

Hi Sergio,

Really thank you for your PR, the version 2.3.0 is out there, please make a try and tell me if your tests pass.

In time, I put the requirement of Capacitor 2.2.1 or newer on readme here.

Best regards,
Bernardo Baumblatt

sergiomilici commented 4 years ago

Hi Bernardo,

I'm happy to contribute to this amazing plugin!

I just tested it and it's working.

Thanks a lot for the quick release!

Best regards, Sergio

curiouscod3 commented 4 years ago

I am using the latest Capacitor(2.3.x) wiith 2.3.1 .. Android Studio complains (No CapConfig)

node_modules/capacitor-firebase-auth/android/src/main/java/com/baumblatt/capacitor/firebase/auth/CapacitorFirebaseAuth.java:15: error: cannot find symbol
import com.getcapacitor.CapConfig;
^
symbol: class CapConfig
location: package com.getcapacitor

sergiomilici commented 4 years ago

Hi @curiouscod3,

I just checked this. I removed my node_modules folder and did a clean install and it's all working. Also, nothing changed in capacitor project. The CapConfig class should be there. I'm using capacitor cli/core/android & ios 2.30 and capacitor-firebase-auth 2.3.1.

I'd recommend you to remove node_modules, make a clean install with the latest versions and then run npx cap update.

Sergio.