refactor: unify firebase imports to recommended syntax

baumblatt / capacitor-firebase-auth

Capacitor Firebase Authentication Plugin

MIT License

261 stars 129 forks source link

refactor: unify firebase imports to recommended syntax #99

Closed mesqueeb closed 4 years ago

mesqueeb commented 4 years ago

@baumblatt some older syntax of how Firebase is imported was remaining in your codebase resulting in the plugin importing the entire development build instead of just the core & auth modules.

This should fix warnings like these that were coming from your plugin:

Fixes #100

alexx855 commented 4 years ago

also getting this warning during dev, with ionic serve, thanks!

mesqueeb commented 4 years ago

@baumblatt Can you review my PR? 😍

mesqueeb commented 4 years ago

Hi everyone! I opened #100 as an issue that points to this PR for extra visibility!! I hope @baumblatt will notice now 😉

hiepxanh commented 4 years ago

can we merge this PR? I think this LGTM

TomBeckett commented 4 years ago

@baumblatt Are there any other maintainers who can merge ?

baumblatt commented 4 years ago

Hi Tom, Luca and others,

First, sorry about the delay on this, the change was released in 2.3.2, please tell me about your tests.

Best regards, Bernardo Baumblatt