search

baumer-lab / fertile

creating optimal conditions for reproducibility
GNU General Public License v3.0
52 stars 4 forks source link

addressed #72 and #73 #75

Closed ambertin closed 4 years ago

ambertin commented 4 years ago

Fixed fs_path / normal path bug mentioned in issue #72. Likely happened because of an update to the fs package that changed the class of paths.

Swapped fs::file_create to usethis::use_readme in the README check to address #73.

Made a few other edits to address notes from R CMD CHECK:

Also, dropped requirements from the list of required packages (since it is now included in fertile) to prevent issues where people get errors when installing fertile that say requirements is not available.

R CMD CHECK now passing on my end!

ambertin commented 4 years ago

It looks like the test for proj_pkg_script() is failing in Travis. The package install script doesn't seem to be generating in the sandbox directory. I have run the check multiple times in different ways on my local computer (including in R CMD CHECK in both the console and with the Check button in the "Build" tab) and the check is working just fine. I have no errors in R CMD CHECK anymore, and on my end, the file gets generated in the temp directory and its contents look correct! Do you have any idea why it could be failing in Travis but not locally? @beanumber.

beanumber commented 4 years ago

Fixed it. The problem was a discrepancy between *.R and *.r.