search

baumer-lab / wikitablr

Simple Reader for Wikipedia Tables
Other
0 stars 0 forks source link

fix tests #6

Open beanumber opened 4 years ago

beanumber commented 4 years ago

Most of the test need to be updated to reflect the refactoring that @niannucci did. The ideas behind the tests should be basically the same, but the syntax will have to be different.

Can @rporta23 and/or @niannucci look into this?

rporta23 commented 4 years ago

Hi Ben,

I would be willing to do this, but I am having some trouble merging the changes from your master repository. I tried to look up how to do it, but it isn't working. If you could remind me of how to do that or point me to a resource that would help that would be great. I remember that you type something vaguely like "git fetch upstream" and then "git merge" into the terminal, but it keeps saying it can't merge. Thanks!

-Rose

On Wed, Apr 29, 2020 at 9:54 AM Ben Baumer notifications@github.com wrote:

Assigned #6 https://github.com/baumer-lab/wikitablr/issues/6 to @rporta23 https://github.com/rporta23.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/baumer-lab/wikitablr/issues/6#event-3284730560, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANATM7NW2EDMMU2ILWHL2WLRPAWRRANCNFSM4MTXXMMQ .

beanumber commented 4 years ago

I think you are referring to this?:

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

beanumber commented 4 years ago

Make sure you have your remotes configured:

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/configuring-a-remote-for-a-fork

rporta23 commented 4 years ago

Thank you! I got it now. Yes, I was looking at that website but I was looking at the wrong tab-- I will start working on updating the tests tomorrow once I finish my finals.

-Rose

On Wed, Apr 29, 2020 at 4:11 PM Ben Baumer notifications@github.com wrote:

Make sure you have your remotes configured:

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/configuring-a-remote-for-a-fork

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/baumer-lab/wikitablr/issues/6#issuecomment-621436743, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANATM7MUS7ZEFM7YZGSRHYDRPCCXLANCNFSM4MTXXMMQ .

beanumber commented 4 years ago

@rporta23 raised some things that still need fixing in #7 .