baumer-lab / wikitablr

Simple Reader for Wikipedia Tables
Other
0 stars 0 forks source link

Attempt at Restructuring tests #7

Closed rporta23 closed 4 years ago

rporta23 commented 4 years ago

I tried to revise the tests but I'm having a lot of issues--for the readers, I'm confused as to how the read_wikinodes function replaces linebreaks in cells with commas when its output isn't even a dataframe (or a list of dataframes). Also, I'm having trouble restructuring the tests where I use a dummy data frame because all of the functions are now supposed to take in a list of data frames, and I don't know how to make a dummy list of data frames. Also I'm getting a lot of errors when I try to apply the cleaning functions and I'm not sure why. There are a bunch of tests in the readers test file that I'm not sure are applicable anymore because of the restructuring (I put a comment indicating which ones), and I'm not sure if they would be applicable to test the cleaning functions or if we should just get rid of them. Maybe you could look at what I did so far and give me some guidance. Thanks!