baumgarr / nixnote2

Nixnote - A clone of Evernote for Linux
http://www.nixnote.org
Other
1.11k stars 158 forks source link

Various minor source code issues in 2.0~beta11 #243

Closed hosiet closed 7 years ago

hosiet commented 7 years ago

While working on Debian packaging of nixnote2 2.0~beta11, the following possible minor issues were found in the source code:

codespell --quiet-level=3 ./main.cpp:105: derivitive ==> derivative ./sql/notetable.cpp:823: Ths ==> The, this


* [ ] RPM packaging issues:
```bash
rpmlint .
/home/hosiet/src/github/nixnote2/package_scripts/webcam_plugin/rpm/nixnote2_webcam_plugin.spec:9: W: hardcoded-packager-tag Randy Baumgarte <randy@fbn.cx>
/home/hosiet/src/github/nixnote2/package_scripts/webcam_plugin/rpm/nixnote2_webcam_plugin.spec:31: W: setup-not-quiet
/home/hosiet/src/github/nixnote2/package_scripts/webcam_plugin/rpm/nixnote2_webcam_plugin.spec: W: no-cleaning-of-buildroot %install
/home/hosiet/src/github/nixnote2/package_scripts/webcam_plugin/rpm/nixnote2_webcam_plugin.spec: W: no-cleaning-of-buildroot %clean
/home/hosiet/src/github/nixnote2/package_scripts/webcam_plugin/rpm/nixnote2_webcam_plugin.spec: W: no-buildroot-tag
/home/hosiet/src/github/nixnote2/package_scripts/webcam_plugin/rpm/nixnote2_webcam_plugin.spec: W: invalid-url Source0: /home/randy/nn2/package_scripts/webcam_plugin/nixnote2_webcam_plugin___VERSION_____ARCH__.tar.gz
/home/hosiet/src/github/nixnote2/package_scripts/rpm/nixnote2.spec:9: W: hardcoded-packager-tag Randy Baumgarte <randy@fbn.cx>
/home/hosiet/src/github/nixnote2/package_scripts/rpm/nixnote2.spec:39: W: setup-not-quiet
/home/hosiet/src/github/nixnote2/package_scripts/rpm/nixnote2.spec: W: no-buildroot-tag
/home/hosiet/src/github/nixnote2/package_scripts/rpm/nixnote2.spec: W: invalid-url Source0: /home/randy/nn2/package_scripts/nixnote2___VERSION_____ARCH__.tar.gz
...

In ./install.sh line 3: package_dir=$(cd dirname $0 && pwd) ^-- SC2046: Quote this to prevent word splitting. ^-- SC2006: Use $(..) instead of legacy ... ^-- SC2086: Double quote to prevent globbing and word splitting.


* Reproducible problems (not really an issue, can be ignored):
```bash
# Prevents reproducible builds: https://reproducible-builds.org/
grep -rE ' __DATE__|__TIME__|__TIMESTAMP__' .
./main.cpp:    QLOG_DEBUG() << "Built on " << __DATE__ << " at " << __TIME__;
baumgarr commented 7 years ago

I corrected the spelling errors. Some of these are just the way it is setup so other scripts can edit them so they are not really errors and the date & time in the logifile are so I can have some idea what version people are using when they send me log files. :)

Thanks.