baumrock / RockMigrations

The Ultimate Automation and Deployment-Tool for ProcessWire
MIT License
34 stars 10 forks source link

Wrong URL in logs #61

Closed matjazpotocnik closed 6 months ago

matjazpotocnik commented 6 months ago

image

<a href="<a href=&quot;editor://open?file=C:/inetpub/wwwroot/site/modules/RockMigrations/RockMigrations.module.php&amp;line=2559&quot;>RockMigrations.module:2559</a>">&lt;a href="editor://open?file=C:/inetpub/ww…</a>

Looks odd to me. Shouldn't this be:

<a href="editor://open?file=C:/inetpub/wwwroot/site/modules/RockMigrations/RockMigrations.module.php&line=2559>Open in editor</a>

BernhardBaumrock commented 6 months ago

Hi @matjazpotocnik thx for the report! Are you talking about these links in the logfile view?

image

The intention here is to get clickable links in the tracy log panel:

image

I was fine with having those ugly links in the core view as a price for that. If you have any better ideas please let me know and reopen the issue.

matjazpotocnik commented 6 months ago

Yes, I'm talking about these links. I don't mind what's the text, the issue I have is that it doesn't open the editor - I get HTTP Error 404.5 - Not Found.

matjazpotocnik commented 6 months ago

This is how it looks here:

image

BernhardBaumrock commented 6 months ago

Yes, it looks the same for me as you can see in the screenshot. I don't know of a way to add links with custom markup to that page. So I ignore that view and made it work just for the tracy panel.

matjazpotocnik commented 6 months ago

Aha, in tracy!

BernhardBaumrock commented 6 months ago

Yes, we'd need a PR for the core to support a feature like this in the core log view. But I didn't really see the need.