bauripalash / fossurl

Your Own Url Shortner Without any fancy server side processing and support for custom url , which can even be hosted on GitHub Pages
MIT License
138 stars 46 forks source link

Not converting protocol correctly when input differs from the allowed. #11

Closed Daniellunsc closed 5 years ago

Daniellunsc commented 6 years ago

When i type something like adasdasd://google.com, it doenst remove the invalid protocol and append the allowed one("http://", "https://", "ftp://").

An example: image

image

The url after: image

bauripalash commented 5 years ago

I found the problem. but couldn't find a way to fix that without messing the whole system. Will try to fix that soon.

agiltriono commented 5 years ago

maybe this is the problem "http://"+url; i only edit that line into url the if statement only return true event if false it still append to json with that value

so user can see notice the url is invalid or not

bauripalash commented 5 years ago

@Daniellunsc The issue is resolved now! Checkout our new design with new improved code : https://fossurl.ml

Daniellunsc commented 5 years ago

Nice! It was fun to contribute.

Enviado do meu iPhone

Em 12 de dez de 2018, à(s) 06:21, Palash Bauri notifications@github.com escreveu:

@Daniellunsc The issue is resolved now! Checkout our new design with new improved code : https://fossurl.ml

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.