bavariancake / XPS9570-macOS

macOS Mojave/Catalina on Dell XPS 9570.
263 stars 45 forks source link

Sleep is not supported #1

Open kevinshroff opened 5 years ago

kevinshroff commented 5 years ago

I have a 9570 - currently using my own Clover folder/patches but does sleep work for you? I can't seem to get it to work

bavariancake commented 5 years ago

I just saw the issue you opened.

Sleep is a work in progress, but seemed to get significantly better with b5f7eb65d311b5f5f6fa1367ea367b2c2b682a75 - Intel acceleration now works after resuming from sleep. Currently the Bluetooth adapter still goes to sleep, so you can't wake with BT mouse/keyboard.

kevinshroff commented 5 years ago

Thank you! With my configuration I wasn't even able to get sleep working but after looking at yours and making some adjustments it seems to be working.

bavariancake commented 5 years ago

Glad to hear. If you make any improvements, please share them via pull request. I'll leave this issue open until sleep is working 100%.

ZhenbPeng commented 5 years ago

in https://github.com/delta-one/dell-xps-15-9570 the author said: Dell removed the S3 sleep-state with BIOS 1.3.0. If you want to use S3, you need to stay on BIOS 1.2.2.

is it 10.14 sleep problem is relation with this?

eamigo86 commented 5 years ago

@kevinshroff can you share you final configuration?

kevinshroff commented 5 years ago

@kevinshroff can you share you final configuration?

I'm working on it - trying to combine bavariancake and xigtun's clover's to get the best of both worlds

d3myz commented 5 years ago

I've also noticed that after "Sleep" or whatever it's doing, when I wake it up, I have no audio. Thoughts?

d3myz commented 5 years ago

@kevinshroff Great youtube vid! you mention you were able to get your xps to sleep. Does that mean it's really sleeping or the screen just turns off? That seems to be what mine does, it appears to sleep, but it still uses quite a bit of battery when "sleeping".

attilagyorffy commented 5 years ago

FYI: I've been doing some research on the net and came across this repository that promises to match @bavariancake's and @xigtun's configurations for a more feature-complete solution. I.e. best of both worlds: https://github.com/LuletterSoul/Dell-XPS-15-9570-macOS-Mojave

I haven't tried it yet but it's on my list of things to do as it apparently offers sleep support.

d3myz commented 5 years ago

The Sleep is the same as on this build. Lulettersoul's build was the first one I tried and it never fully worked for me. Also if you have a 4k screen his build only gives you 2.5-3 hours of battery life, not sure if that's been updated, but I get at least 4-5 with this build. I believe the issue is that the computer won't hibernate when sleeping. after fully charging my hack, I left it in sleep unplugged for 6 hours and the battery was at 60% when i woke it up. It's easier just to shut it down, but it would be nice if real sleep worked.

attilagyorffy commented 5 years ago

@d3myz good to know, thank you.