search

bavc / qctools

QCTools (Quality Control Tools for Video Preservation) is a free and open source software tool that helps users analyze and understand their digitized video files through use of audiovisual analytics and filtering. QCTools is funded by the National Endowment for the Humanities and the Knight Foundation, and is developed by the Bay Area Video Coalition.
http://www.bavc.org/qctools
Other
307 stars 41 forks source link

conditional graphing for based upon bit depth #188

Closed dericed closed 8 years ago

dericed commented 8 years ago

Now that signalstats supports >8 bit (thanks @richardpl), many graphs need to be adjusted to plot in the appropriate range (0-255 or 0-1023).

In the video group array, there's a min/max y-axis value set for many graphs.

The guidelines (for broadcast range and notable saturation levels) also need conditional adjustment.

richardpl commented 8 years ago

Can't min/max be auto extended to max/min possible value like for audio?

dericed commented 8 years ago

Ultimately I'd like it to be possible to plot the graph in either mean: plot based on min to max or plot within the context of greatest possible min and max.

kieranjol commented 8 years ago

I was going to raise a separate issue but I think this is the same one? 10-bit video is now described with 10-bit values but some of the graphs are not scaling and are cutting off the views at 8-bit values. Edit: I'm using ffmpeg and qctools git head on El Capitan.

screen shot 2016-09-13 at 10 40 32

dericed commented 8 years ago

To recreate, make these two samples:

ffmpeg -f lavfi -i color=color=black:r=1 -vf geq=lum=N -c:v ffv1 -t 256 8bit.mkv
ffmpeg -f lavfi -i color=color=black:r=1 -vf geq=lum=N -c:v ffv1 -pix_fmt yuv444p10le -t 256 10bit.mkv

{sorry @richardpl no way to use frame number or time as variable in lut).

8bit.mkv and 10bit.mkv should produce ramps in QCTools in the Y, U, and V graphs from min-max. In 8 bit that's 0-255 and 10 bit that's 0-1023 (though the sample uses only multiples of 4 between 0 and 1023). Currently as with @kieranjol's image the 10 bit is plotted from 0-255 so values 256-1023 are cut of.

Can access bit depth from stream:bits_per_raw_sample.

dericed commented 8 years ago

Fixed in https://github.com/bavc/qctools/pull/196